[icinga-checkins] icinga.org: icinga-core/mfriedrich/core: introduce common/shared. c and include/shared.h (Andreas Ericsson)

git at icinga.org git at icinga.org
Tue May 11 18:31:47 CEST 2010


Module: icinga-core
Branch: mfriedrich/core
Commit: f8ee80103deab47dc450b954aa7207feec7d879d
URL:    https://git.icinga.org/?p=icinga-core.git;a=commit;h=f8ee80103deab47dc450b954aa7207feec7d879d

Author: Michael Friedrich <michael.friedrich at univie.ac.at>
Date:   Tue May 11 18:31:00 2010 +0200

introduce common/shared.c and include/shared.h (Andreas Ericsson)

[--snip--]
A lot of functionality was previously duplicate between base/utils.c
and cgi/cgiutils.c, but with some minor code-rot between the various
versions, depending on when bugs were found where. This consolidates
the two files into a new one, which is compile-state independent and
thus doesn't require re-compilation between compiling cgis and
Nagios.

Minor bugs that were previously fixed in either the daemon or the
cgi's are now fixed in both (assuming my manual code analysis is
correct anyways).

This change was long overdue. Now we just need to keep duplicate
code from entering the repository again.
[--snip--]

slightly modified to fit into Icinga.

fixes #389

---

 Changelog             |    1 +
 base/Makefile.in      |    6 +-
 base/utils.c          |  510 ------------------------------------------------
 cgi/Makefile.in       |    4 +-
 cgi/cgiauth.c         |    2 +-
 cgi/cgiutils.c        |  464 --------------------------------------------
 common/.gitignore     |    1 +
 common/shared.c       |  511 +++++++++++++++++++++++++++++++++++++++++++++++++
 include/cgiutils.h.in |   28 ---
 include/common.h      |    1 +
 include/icinga.h      |   27 ---
 include/shared.h      |   31 +++
 12 files changed, 553 insertions(+), 1033 deletions(-)

Diff:   https://git.icinga.org/?p=icinga-core.git;a=commitdiff;h=f8ee80103deab47dc450b954aa7207feec7d879d




More information about the icinga-checkins mailing list