[icinga-checkins] icinga.org: icinga-core/mfriedrich/workers: core: remove embedded perl functionality and libs #2948

git at icinga.org git at icinga.org
Sun Aug 5 23:32:12 CEST 2012


Module: icinga-core
Branch: mfriedrich/workers
Commit: 622500ef1389d68cced92cdf628f580c5c364812
URL:    https://git.icinga.org/?p=icinga-core.git;a=commit;h=622500ef1389d68cced92cdf628f580c5c364812

Author: Michael Friedrich <michael.friedrich at univie.ac.at>
Date:   Sun Aug  5 12:56:21 2012 +0200

core: remove embedded perl functionality and libs #2948

this affects mainly the libs (p1.pl.in and the tools in contrib) as well
as function header's removal, as well as dropping all #ifdef's from the
source.

as noted in #2948, we should implemented embedded perl again in (a)
dedicated core worker(s) (see #2910). needed files can be restored from git history
if needed, so we'll wipe the for now. furthermore, the configure options
should be renamed to reflect that the workers will require embedded perl
(this should rather happen within libicinga too).

the main reason for dropping embedded perl at first sight is as well -
the past showed that the cached perl checks leak memory, and the
performance gain resulted in memory bloated processes on the checks.
some people created a cron restarting their daemon every night, others
just might use mod_gearman where the workers have their own embedded
perl implemented (and will be restarted once every while). and others
just let the core fork into a child calling the script interpreter -
saving memory, but hogging the cpu a bit more. the last option should
work even better with the worker jobs, not blocking the core anymore,
passing the checkresults back in memory too.

refs #2948

---

 Makefile.in                |    9 +-
 OutputTrap.pm              |   39 --
 base/Makefile.in           |    6 +-
 base/checks.c              |    8 -
 base/config.c              |   66 +---
 base/icinga.c              |   32 +--
 base/utils.c               |  274 --------------
 configure                  |  639 +++++++++++++--------------------
 configure.in               |   74 +----
 contrib/Makefile.in        |   15 +-
 contrib/README             |   20 +-
 contrib/epn_icinga.h       |   28 --
 contrib/mini_epn.c         |  121 -------
 contrib/new_mini_epn.c     |  256 -------------
 contrib/p1.pl              |  854 --------------------------------------------
 icinga.spec                |    4 +-
 include/config.h.in        |    6 -
 include/epn_icinga.h       |   53 ---
 include/icinga.h           |    6 -
 include/locations.h.in     |    2 -
 p1.pl.in                   |  777 ----------------------------------------
 subst.in                   |    1 -
 t-tap/Makefile.in          |    2 -
 t-tap/test_icinga_config.c |    6 -
 t-tap/test_timeperiods.c   |    6 -
 25 files changed, 276 insertions(+), 3028 deletions(-)

Diff:   https://git.icinga.org/?p=icinga-core.git;a=commitdiff;h=622500ef1389d68cced92cdf628f580c5c364812




More information about the icinga-checkins mailing list