[icinga-devel] branch testing

Hiren Patel hir3npatel at gmail.com
Sat May 22 14:14:09 CEST 2010


hi guys,
branch hpatel/core has bug track items:
312 - event profiling
436 - execv to execute checks where possible
306 - state base escalation

any testing around these will be much appreciated.

due to 436, how checks are defined and called become a little more strict,
eg. in the default config check_ssh is defined as:
command_line    $USER1$/check_ssh $ARG1$ $HOSTADDRESS$
but called as:
check_command                   check_ssh
(no argument given when one expected)

redefining the check to:
command_line    $USER1$/check_ssh $HOSTADDRESS$
solves it for this check
(the checks need to be defined and called accordingly, which IMHO is a good thing)

436 will use execv to execute this check so extra/blank arguments and or spaces aren't taken care of by the shell any longer.
the tracker item is to run checks that don't have shell meta characters using execv instead of popen, saving one fork() to run this check.

312 also includes the event profile data in the cgi 'performance info' section below "buffer usage" when enabled in the config file.
the new config option in icinga.cfg as I have it,is event_profiling_enabled=1

any testing and reporting appreciated.
note, these are in hpatel/core only for now, not applied to master.
thanks.

-- 
Hiren Patel <hir3npatel at gmail.com>




More information about the icinga-devel mailing list